From 392a42ada60670f4f8212da746e25889f0ed2299 Mon Sep 17 00:00:00 2001 From: Frederick Muriuki Muriithi Date: Thu, 30 Nov 2023 10:44:15 +0300 Subject: Error logging: Add more details to help with debugging. --- qc_app/errors.py | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/qc_app/errors.py b/qc_app/errors.py index 06c5dd4..7af7696 100644 --- a/qc_app/errors.py +++ b/qc_app/errors.py @@ -3,21 +3,17 @@ import logging import traceback import MySQLdb as mdb -from flask import Flask, render_template +from flask import Flask, request, render_template -def handle_general_exception(_exc: Exception): +def handle_general_exception(exc: Exception): """Handle generic exceptions.""" trace = traceback.format_exc() - logging.error("Error: Generic unhandled exception!!\n%s", trace) - return render_template("unhandled_exception.html", trace=trace) - -def handle_general_mysqldb_errors(_exc: mdb.MySQLError): - """Handle MySQLdb errors.""" - trace = traceback.format_exc() - logging.error("MySQLError: Generic MySQL Error!!\n%s", trace) + logging.error( + "Error (%s.%s): Generic unhandled exception!! (URI: %s)\n%s", + exc.__class__.__module__, exc.__class__.__name__, request.url, trace) return render_template("unhandled_exception.html", trace=trace) def register_error_handlers(app: Flask): """Register top-level error/exception handlers.""" app.register_error_handler(Exception, handle_general_exception) - app.register_error_handler(mdb.MySQLError, handle_general_mysqldb_errors) + app.register_error_handler(mdb.MySQLError, handle_general_exception) -- cgit v1.2.3