From 8e4ebe14da610de84cd1f53eb491e7c50cd3d781 Mon Sep 17 00:00:00 2001 From: Frederick Muriuki Muriithi Date: Thu, 24 Jul 2025 13:37:22 -0500 Subject: Deactivate a check that's likely wrong - add a note. --- tests/unit/test_privileges_spec_parsing.py | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) (limited to 'tests/unit') diff --git a/tests/unit/test_privileges_spec_parsing.py b/tests/unit/test_privileges_spec_parsing.py index 88b15fc..124f570 100644 --- a/tests/unit/test_privileges_spec_parsing.py +++ b/tests/unit/test_privileges_spec_parsing.py @@ -153,12 +153,16 @@ def test_complex(spec, expected): @pytest.mark.unit_test @pytest.mark.parametrize( "spec,expected", - (("(AND priv1 (or priv2 priv3) priv4 (or priv5 priv6))", - ("AND", - ("priv1", "priv4"), - ("OR", ("priv2", "priv3", "priv5", "priv6")))), - ("(OR priv1 (or priv2 priv3 (or priv4 priv5)) (or priv6 priv7))", - ("OR", ("priv1", "priv6", "priv7", "priv2", "priv3", "priv4", "priv5"))))) + ( + # -- We need to be careful about reduction -- + # -- Please revisit your boolean logic to verify -- + # -- how to reduce boolean statements. -- + # ("(AND priv1 (or priv2 priv3) priv4 (or priv5 priv6))", + # ("AND", + # ("priv1", "priv4"), + # ("OR", ("priv2", "priv3", "priv5", "priv6")))), + ("(OR priv1 (or priv2 priv3 (or priv4 priv5)) (or priv6 priv7))", + ("OR", ("priv1", "priv6", "priv7", "priv2", "priv3", "priv4", "priv5"))),)) def test_reduction(spec, expected): """ GIVEN: A spec that can be reduced -- cgit v1.2.3