From 9fc3158bffac84b465915fe1918e3aa34de27a2f Mon Sep 17 00:00:00 2001
From: Frederick Muriuki Muriithi
Date: Thu, 20 Oct 2022 07:00:20 +0300
Subject: Issues (dataset_queried_twice): New issue

* issues/dataset_queried_twice.gmi: New issue
---
 issues/dataset_queried_twice.gmi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 issues/dataset_queried_twice.gmi

(limited to 'issues')

diff --git a/issues/dataset_queried_twice.gmi b/issues/dataset_queried_twice.gmi
new file mode 100644
index 0000000..aa726da
--- /dev/null
+++ b/issues/dataset_queried_twice.gmi
@@ -0,0 +1,19 @@
+# Dataset Queried Twice
+
+## Tags
+
+* assigned:
+* type: bug
+* priority: medium
+* keywords: performance enhancement, optimisation
+* status: pending
+
+## Description
+
+In the function
+=> https://github.com/genenetwork/genenetwork2/blob/6457f7e3516a04e238eeb061db358eea29cd2332/wqflask/base/trait.py#L21-L50 base.trait.create_trait
+the dataset is queried twice:
+* once in lines 30 to 33
+* once in the call to GeneralTrait (line 42) - lines 67 to 74
+
+Maybe, pass the dataset created in lines 30 to 33 to GeneralTrait to avoid re-querying the data.
-- 
cgit v1.2.3