From 57f99c69dd86cf25b2d7f290eb415a11c9cd167c Mon Sep 17 00:00:00 2001 From: Frederick Muriuki Muriithi Date: Tue, 28 Nov 2023 09:49:49 +0300 Subject: Close issue. --- issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'issues') diff --git a/issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi b/issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi index b86e3da..525264d 100644 --- a/issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi +++ b/issues/editing-bug-conflating-dataset_id-with-inbred_set_id.gmi @@ -3,13 +3,17 @@ ## Tags * type: bug -* status: open +* status: closed * assigned: fredm, bonz * keywords: editing * priority: critical ## Description +The issue described here should no longer exist after all the changes done for the editing work. + +---- + The existing code that handles editing of phenotypes conflates the `dataset_id` with the `inbred_set_id` in a number of places. This is a subtle, but insidious bug that might lead to the end user editing the wrong data, if the values for both these values ever differs. We need to do the appropriate indirections to fetch the group (InbredSet) details from the `dataset_id`. -- cgit v1.2.3