From 287c6f7fef50821748588e681c91a8a3a3ae9bf6 Mon Sep 17 00:00:00 2001 From: BonfaceKilz Date: Tue, 12 Apr 2022 13:35:07 +0300 Subject: Close issue 161 --- issues/csv-error-ITP_10001-longevity-data-set.gmi | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) (limited to 'issues/csv-error-ITP_10001-longevity-data-set.gmi') diff --git a/issues/csv-error-ITP_10001-longevity-data-set.gmi b/issues/csv-error-ITP_10001-longevity-data-set.gmi index 830f96d..140267a 100644 --- a/issues/csv-error-ITP_10001-longevity-data-set.gmi +++ b/issues/csv-error-ITP_10001-longevity-data-set.gmi @@ -4,9 +4,9 @@ * assigned: bonfacem * type: bug +* status: closed * priority: critical -* keywords: critical bug, in progress -* keywords: metadata, phenotypes +* keywords: critical bug, in progress, metadata, phenotypes ## Description @@ -26,9 +26,11 @@ The screenshot: - [X] Check if database is affected in any way -- [ ] Send a patch to fix +- [X] Send a patch to fix -- [ ] Notify every relevant user +- [X] Notify every relevant user + +- [X] Update case-attr page with links ## Notes @@ -49,3 +51,11 @@ Notice the "^M" represents a carriage return. See: => https://en.wikipedia.org/wiki/ANSI_escape_code#C0_control_codes When storing case attributes, values with control sequences are also stored, and when you download that data for use, they were not being stripped out. As a consequence, opening the csv file in Excel (or similar) software resulted in data that seems jumbled up. + +### Tue 12 Apr 2022 13:33:31 EAT + +The relevant fixes: + +=> https://github.com/genenetwork/genenetwork2/pull/697 + +=> https://github.com/genenetwork/genenetwork3/pull/91 -- cgit v1.2.3