From 61530ef4f3ce2c7ad6a617a683160ea081680a03 Mon Sep 17 00:00:00 2001 From: jgart Date: Thu, 28 Oct 2021 20:40:21 -0400 Subject: Add return-canned-text-if-notebook-description-returns-none issue --- ...d-text-if-notebook-description-returns-none.gmi | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 issues/binderlite/return-canned-text-if-notebook-description-returns-none.gmi (limited to 'issues/binderlite') diff --git a/issues/binderlite/return-canned-text-if-notebook-description-returns-none.gmi b/issues/binderlite/return-canned-text-if-notebook-description-returns-none.gmi new file mode 100644 index 0000000..49f5d3f --- /dev/null +++ b/issues/binderlite/return-canned-text-if-notebook-description-returns-none.gmi @@ -0,0 +1,25 @@ +# Return canned text if notebook description returns none + +* bug? +* assigned: jgart + +Notebooks that do not have a description will use python's `None` value as the +project's description. + +Should we return some other text instead? + +We could do something like the following idea: + +``` +if notebook.description == None: + return "Project does not have a description." +``` + +Or we could do: + +``` +if notebook.description == None: + return "Could not retrieve description for project." +``` + +WDYT? -- cgit v1.2.3 From f74813e97dee960379fdbffd733597dd7ed404d7 Mon Sep 17 00:00:00 2001 From: jgart Date: Thu, 28 Oct 2021 20:49:19 -0400 Subject: Add integrate-styling-with-gn2 issue --- issues/binderlite/integrate-styling-with-gn2.gmi | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 issues/binderlite/integrate-styling-with-gn2.gmi (limited to 'issues/binderlite') diff --git a/issues/binderlite/integrate-styling-with-gn2.gmi b/issues/binderlite/integrate-styling-with-gn2.gmi new file mode 100644 index 0000000..dc158fa --- /dev/null +++ b/issues/binderlite/integrate-styling-with-gn2.gmi @@ -0,0 +1,11 @@ +# Integrate styling of app with GN2 + +* ongoing +* assigned: jgart + +Currently using antiweb for styling with modifications. + +=> https://git.sr.ht/~sircmpwn/antiweb antiweb + +Copying nav bar and fonts from GN2 will make the app look more integrated with +GN2 UI. -- cgit v1.2.3 From 6c9b4acc6e9e210bf174967f1ed6294dd64a71d6 Mon Sep 17 00:00:00 2001 From: jgart Date: Thu, 28 Oct 2021 20:58:51 -0400 Subject: Adds ansi2html feature for binderlite issue --- .../ansi2html_terminal_user_feedback.gmi | 36 +++++++++++++++++++++ .../binderlite_ansi2html_terminal_diagram.png | Bin 0 -> 8784 bytes 2 files changed, 36 insertions(+) create mode 100644 issues/binderlite/ansi2html_terminal_user_feedback.gmi create mode 100644 issues/binderlite/binderlite_ansi2html_terminal_diagram.png (limited to 'issues/binderlite') diff --git a/issues/binderlite/ansi2html_terminal_user_feedback.gmi b/issues/binderlite/ansi2html_terminal_user_feedback.gmi new file mode 100644 index 0000000..969448a --- /dev/null +++ b/issues/binderlite/ansi2html_terminal_user_feedback.gmi @@ -0,0 +1,36 @@ +# ansi2html terminal user feedback + +* ongoing +* feature-request +* assigned: jgart + +https://builds.sr.ht/~sircmpwn/job/610711 + +https://builds.sr.ht/~sircmpwn/job/611028 + +This issue proposes an alternative way to generate terminal output to the browser +from a process that does not dependent on js libraries but still looks great. + +Drew Devault uses this method in builds.sr.ht, the continuous integration +system/app that is part of the SourceHut suite. + +builds.sr.ht generates terminal output using jinja templates and a relatively +small python library called ansi2html. It is already packaged by guix upstream +as python-ansi2html (It could use an update). + +https://github.com/pycontribs/ansi2html +https://pypi.org/project/ansi2html/ + +Here are two examples of it in action at builds.sr.ht: + +https://builds.sr.ht/~sircmpwn/job/610711 + +https://builds.sr.ht/~sircmpwn/job/611028 + +And, the relevant places in builds.sr.ht code base: + +https://git.sr.ht/~sircmpwn/builds.sr.ht/tree/master/item/buildsrht/templates/job.html#L117 + +https://git.sr.ht/~sircmpwn/builds.sr.ht/tree/master/item/buildsrht/blueprints/jobs.py#L333 + +I've added a diagram showing how it will integrate with binderlite. diff --git a/issues/binderlite/binderlite_ansi2html_terminal_diagram.png b/issues/binderlite/binderlite_ansi2html_terminal_diagram.png new file mode 100644 index 0000000..a4f16b4 Binary files /dev/null and b/issues/binderlite/binderlite_ansi2html_terminal_diagram.png differ -- cgit v1.2.3 From 1793406aa06b4320d4731cbc9bd5bb7b37f8393d Mon Sep 17 00:00:00 2001 From: jgart Date: Thu, 4 Nov 2021 22:49:00 -0400 Subject: issues: Open notebook directly if full path to notebook file is given --- .../open-files-directly-if-full-path-is-given.gmi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 issues/binderlite/open-files-directly-if-full-path-is-given.gmi (limited to 'issues/binderlite') diff --git a/issues/binderlite/open-files-directly-if-full-path-is-given.gmi b/issues/binderlite/open-files-directly-if-full-path-is-given.gmi new file mode 100644 index 0000000..2fb4b2f --- /dev/null +++ b/issues/binderlite/open-files-directly-if-full-path-is-given.gmi @@ -0,0 +1,16 @@ +# Open notebook directly if full path to notebook file is given + +* feature-request +* assigned: jgart + +We'd like to be able launch a notebook directly if the user gives the fullpath to the notebook file. + +Should we allow urls like this? + +https://github.com/jgarte/guile-notebook-genenetwork-api/blob/master/genenetwork-api.ipynb + +The above is a valid github url that also points to the notebook file. + +Or only this? + +https://github.com/jgarte/guile-notebook-genenetwork-api/genenetwork-api.ipynb -- cgit v1.2.3 From b4df0131b5c4cf9ba1e48d66f5c47b38aafdd394 Mon Sep 17 00:00:00 2001 From: jgart Date: Wed, 10 Nov 2021 14:24:51 -0500 Subject: binderlite: Add server name configuration feature --- issues/binderlite/add-configuration-to-set-server-name.gmi | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 issues/binderlite/add-configuration-to-set-server-name.gmi (limited to 'issues/binderlite') diff --git a/issues/binderlite/add-configuration-to-set-server-name.gmi b/issues/binderlite/add-configuration-to-set-server-name.gmi new file mode 100644 index 0000000..d54997c --- /dev/null +++ b/issues/binderlite/add-configuration-to-set-server-name.gmi @@ -0,0 +1,11 @@ +# Add configuration to set server name + +* assigned: jgart + +* feature + +Let's use environment variables as configuration + +https://flask.palletsprojects.com/en/2.0.x/cli/?highlight=environment%20variables + +https://docs.python.org/3/library/os.html?highlight=os%20environ#os.environ -- cgit v1.2.3 From 2d7e532a4a231c743e313231ff4cfdb23e6de75f Mon Sep 17 00:00:00 2001 From: jgart Date: Wed, 10 Nov 2021 14:29:23 -0500 Subject: issue: binderlite: Close spinner for submit form --- issues/binderlite/add-spinner-for-submit-form.gmi | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'issues/binderlite') diff --git a/issues/binderlite/add-spinner-for-submit-form.gmi b/issues/binderlite/add-spinner-for-submit-form.gmi index 0800fa8..de19c55 100644 --- a/issues/binderlite/add-spinner-for-submit-form.gmi +++ b/issues/binderlite/add-spinner-for-submit-form.gmi @@ -13,3 +13,15 @@ a container to be built? A spinning guix gnu logo could be cool. https://www.w3schools.com/howto/howto_css_loader.asp https://spin.js.org/https://spin.js.org/ + + +## Solution + +We're using ansi2html now. + +See the following issue: + +=> ./ansi2html_terminal_user_feedback.gmi + +* closed + -- cgit v1.2.3 From 640c2dccf8933be8de98352d45ccb4364fd9b986 Mon Sep 17 00:00:00 2001 From: jgart Date: Wed, 10 Nov 2021 14:31:31 -0500 Subject: issues: binderlite: Close nginx forwarding error regarding static assets --- issues/binderlite/error-regarding-static-assets-after-forwarding.gmi | 2 ++ 1 file changed, 2 insertions(+) (limited to 'issues/binderlite') diff --git a/issues/binderlite/error-regarding-static-assets-after-forwarding.gmi b/issues/binderlite/error-regarding-static-assets-after-forwarding.gmi index 27e7bd1..bd39df9 100644 --- a/issues/binderlite/error-regarding-static-assets-after-forwarding.gmi +++ b/issues/binderlite/error-regarding-static-assets-after-forwarding.gmi @@ -50,3 +50,5 @@ http://localhost/49761/?token=f6269bbf48ee5c9887732f5bc76d32f37e1f25483195ae88 The next step is to get jupyter to accept the generated token on the first request without needing to input it manually first. + +* closed -- cgit v1.2.3 From 74ef08481243820503f543b103f3a6dbb8a3a61f Mon Sep 17 00:00:00 2001 From: jgart Date: Wed, 10 Nov 2021 14:33:11 -0500 Subject: issues: binderlite: Close open notebook directly feature --- issues/binderlite/open-files-directly-if-full-path-is-given.gmi | 2 ++ 1 file changed, 2 insertions(+) (limited to 'issues/binderlite') diff --git a/issues/binderlite/open-files-directly-if-full-path-is-given.gmi b/issues/binderlite/open-files-directly-if-full-path-is-given.gmi index 2fb4b2f..203e87a 100644 --- a/issues/binderlite/open-files-directly-if-full-path-is-given.gmi +++ b/issues/binderlite/open-files-directly-if-full-path-is-given.gmi @@ -14,3 +14,5 @@ The above is a valid github url that also points to the notebook file. Or only this? https://github.com/jgarte/guile-notebook-genenetwork-api/genenetwork-api.ipynb + +* closed -- cgit v1.2.3