From ef8f6d9ec1963f5a26d8250107b48c96c65193da Mon Sep 17 00:00:00 2001 From: zsloan Date: Mon, 7 Nov 2022 17:10:40 -0600 Subject: Update correlations-return-fewer-results --- issues/correlations-return-fewer-results | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/issues/correlations-return-fewer-results b/issues/correlations-return-fewer-results index 699754c..784e50d 100644 --- a/issues/correlations-return-fewer-results +++ b/issues/correlations-return-fewer-results @@ -24,4 +24,10 @@ an example of such a case is computing the below dataset against the against BX Probably causes are :- -=> https://github.com/genenetwork/gn-gemtext-threads/blob/main/issues/fix-include-f1-parents-correlations.gmi \ No newline at end of file +=> https://github.com/genenetwork/gn-gemtext-threads/blob/main/issues/fix-include-f1-parents-correlations.gmi + +## Updates + +The samplelist issue doesn't appear to be causing the issue with fewer results, since it still exists after the fix. There also seems to be an additional - or related - issue where it's either returning wrong results or not returning the actual top results (or both) + +Using the sample example above, after the change, the first result has a sample(r) of 0.265. This isn't the top result when run in GN1. There also appears to be a mismatch between the result displayed in the table and the r displayed in the scatterplot (what you see if you click the sample(r) link); those should be roughly the same. -- cgit v1.2.3