From ec83534528ad6053a6d5089b751e3663ff4e7db8 Mon Sep 17 00:00:00 2001 From: Munyoki Kilyungi Date: Tue, 17 Sep 2024 11:57:15 +0300 Subject: Update ADR/gn3/000. Signed-off-by: Munyoki Kilyungi --- topics/ADR/gn3/000-remove-stace-traces-in-gn3-error-response.gmi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/topics/ADR/gn3/000-remove-stace-traces-in-gn3-error-response.gmi b/topics/ADR/gn3/000-remove-stace-traces-in-gn3-error-response.gmi index 7c0c7d6..37fa477 100644 --- a/topics/ADR/gn3/000-remove-stace-traces-in-gn3-error-response.gmi +++ b/topics/ADR/gn3/000-remove-stace-traces-in-gn3-error-response.gmi @@ -43,3 +43,7 @@ Stack traces have the potential to allow malicious actors compromise our system ## Consequences * Lockstep update in GN2 UI on how we handle GN3 errors. + +## Notes + +ADR rejected. Currently, having stack traces are a convenient feature for situations where bugs are being reported to us by others. It's not always easy to reproduce the issue in question and check logs (since they wouldn't show up in production and would need to de reproduced locally); therefore having stack traces available in such situations can be very useful. To also get rid of the stack traces, then we'd have to link each trace in the logs with the request that caused it, so during troubleshooting, we can correlate and endpoint to an error and it's trace. -- cgit v1.2.3