From 9fa69a48e3faf7905d89479e26d12f7abe6d8fb4 Mon Sep 17 00:00:00 2001 From: Frederick Muriuki Muriithi Date: Tue, 12 Apr 2022 11:51:53 +0300 Subject: Update issue with some findings --- issues/sql-too-many-connections.gmi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/issues/sql-too-many-connections.gmi b/issues/sql-too-many-connections.gmi index e80beaa..f8db41b 100644 --- a/issues/sql-too-many-connections.gmi +++ b/issues/sql-too-many-connections.gmi @@ -16,3 +16,12 @@ See the strack trace present in this page: => https://ci.genenetwork.org/jobs/genenetwork2/214 + + +### Debug notes + +The function decorated with `@app.before_requests` is called before every request, even ones retrieving static files like CSS and JS files. This executes the `sqlalchemy.create_engine(...)' statement many times for each page. + +I started by checking whether the request is to a *static* or *js* endpoint, and if it is, we do not bother trying to create the engine in that case. + +This does not resolve the issue per-se, but it does reduce a lot of the noise when logging. -- cgit v1.2.3