From 6824c09bd7fd29af451a94e4a8c2fcda25282960 Mon Sep 17 00:00:00 2001 From: Frederick Muriuki Muriithi Date: Mon, 16 May 2022 12:19:26 +0300 Subject: New issue: Menu generation improvements --- .../improve-menu-generation-and-move-it-to-gn3.gmi | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 issues/improve-menu-generation-and-move-it-to-gn3.gmi diff --git a/issues/improve-menu-generation-and-move-it-to-gn3.gmi b/issues/improve-menu-generation-and-move-it-to-gn3.gmi new file mode 100644 index 0000000..b621cbe --- /dev/null +++ b/issues/improve-menu-generation-and-move-it-to-gn3.gmi @@ -0,0 +1,25 @@ +# Improve Menu Generation and Move it to GN3 + +## Tags + +* assigned: fredm +* type: bug +* priority: medium +* status: pending +* keywords: menu generation, GN2, GN3 + +## Description + +The +=> https://github.com/genenetwork/genenetwork2/blob/testing/wqflask/wqflask/api/gen_menu.py#L6-L17 gen_dropdown_json +function calls functions that make queries to the database within loops. + +This ruins the performance of the system significantly. + +The queries should be reworked, and the code should be moved to GN3 since it does database access. + +### TODOs + +* [ ] Rework the queries: don't run queries inside loops +* [ ] Move the code to GN3 +* [ ] Provide results of function at an endpoint in GN3 -- cgit v1.2.3