From 46492e3bb16f59b6a24502715abdbb18b6680da9 Mon Sep 17 00:00:00 2001 From: Munyoki Kilyungi Date: Wed, 12 Oct 2022 17:51:37 +0300 Subject: Close issue WRT 404 in logs * issues/genenetwork/issue-404-in-logs.gmi: (front-matter): Delete. (body) Close issue after adding some extra [resolution] information. --- issues/genenetwork/issue-404-in-logs.gmi | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/issues/genenetwork/issue-404-in-logs.gmi b/issues/genenetwork/issue-404-in-logs.gmi index 8e69838..0680ec7 100644 --- a/issues/genenetwork/issue-404-in-logs.gmi +++ b/issues/genenetwork/issue-404-in-logs.gmi @@ -5,10 +5,9 @@ * type: enhancement * keywords: deployment, 404 * assigned: bonfacem, pjotrp -* status: unclear * priority: low -## Notes +## Introduction => https://flask.palletsprojects.com/en/2.0.x/errorhandling/ @@ -58,3 +57,22 @@ I'll look a way for removing this: ``` with a more sane, but probably still useful, log. That's where I problem IIUC lies. + +### Resolution + +The problem of improving better logging has been documented in: + +=> /topics/better-logging + +Most recently, all noisy logging was removed in: + +=> https://github.com/genenetwork/genenetwork2/pull/730/commits/313b041a1c382042b6028054c6c17218eed1c9c5 Delete logger import (commit) + +=> https://github.com/genenetwork/genenetwork2/pull/730/commits/afe2bd8ce689994da6f2f0cca420b472ee3b7fff Delete utility.logger (commit) + +=> https://github.com/genenetwork/genenetwork2/commit/9d0f492d8a999c1a3eb6525b0ae72bbbcaad4279 Remove usage of "logger" and un-necessary comments wrt the same + +We are aware that at the moment we are using one error-handler for everything, and this, together with any other logging issues should be tackled in another separate issue. + +* closed + -- cgit v1.2.3