From 3b4666bd10e68cff158200b3ed58fa490a971bd7 Mon Sep 17 00:00:00 2001 From: BonfaceKilz Date: Wed, 6 Apr 2022 17:48:48 +0300 Subject: Close issue on fixing case attributes --- issues/fix-case-attribute-work.gmi | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/issues/fix-case-attribute-work.gmi b/issues/fix-case-attribute-work.gmi index 08462bf..3724998 100644 --- a/issues/fix-case-attribute-work.gmi +++ b/issues/fix-case-attribute-work.gmi @@ -1,19 +1,35 @@ -# Fix Case Attribute Work +# Fix Case Attribute Work (Same Columns) ## Tags * assigned: bonfacem * type: bug -* keywords: case attributes, data editing +* keywords: case attributes, data editing, done ## Tasks -* [ ] Parse things in "brackets" -* [ ] When editing columns with the same header: -* [ ] Check whether there's an ID. If so: -* [ ] Get the case attribute ID in brackets when in caseattributeXRef -* [ ] Else, do the fetching in SQL -* [ ] Check whether there's an -* [ ] Rollbacks ("conn.rollback()") -* [ ] Consecutive inserts with same values -* [ ] Consecutive deletions +* [x] Parse things in "brackets" +* [x] When editing columns with the same header: +* [x] Check whether there's an ID. If so: +* [x] Get the case attribute ID in brackets when in caseattributeXRef +* [x] Else, do the fetching in SQL +* [x] Check whether there's an +* [x] Rollbacks ("conn.rollback()") +* [-] Consecutive inserts with same values +* [-] Consecutive deletions + +### Notes: 06/04/22 + +Most of these issues have been addressed in these 2 PRs: + +=> https://github.com/genenetwork/genenetwork3/pull/90 +=> https://github.com/genenetwork/genenetwork2/pull/695 + +The last 2 elements in the tasks have been moved out to their own tasks. + +=> https://github.com/genenetwork/gn-gemtext-threads/commit/a75b726a008012b83c1ad25b330d43aabd711ee3 + +Also, wrt UI issues see: + +=> https://issues.genenetwork.org/issues/metadata-edits-improvements.html + -- cgit v1.2.3