From 2ebc99cf340547a7276209cf39a54caad62a1bb6 Mon Sep 17 00:00:00 2001 From: Frederick Muriuki Muriithi Date: Mon, 5 Oct 2026 10:11:45 -0500 Subject: fix (resources/base): Make `created_by` mandatory. The `created_by` field is mandatory, and every resource should have a creator, including the system itself. Any chicken/egg situation that arises from this situation should be resolved by manually editing the data or building code to initialise the application at startup, not by ignoring this invariant. --- gn_auth/scripts/batch_assign_data_to_default_admin.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'gn_auth/scripts/batch_assign_data_to_default_admin.py') diff --git a/gn_auth/scripts/batch_assign_data_to_default_admin.py b/gn_auth/scripts/batch_assign_data_to_default_admin.py index 95d9794..862c4bd 100644 --- a/gn_auth/scripts/batch_assign_data_to_default_admin.py +++ b/gn_auth/scripts/batch_assign_data_to_default_admin.py @@ -16,7 +16,7 @@ from gn_auth.auth.authentication.users import User from gn_auth.auth.authorisation.resources.groups.models import ( Group, db_row_to_group) from gn_auth.scripts.assign_data_to_default_admin import ( - default_resources, assign_data_to_resource) + sys_admins, default_resources, assign_data_to_resource) def resources_group(conn: authdb.DbConnection) -> Maybe: @@ -48,10 +48,10 @@ def resource_owner(conn: authdb.DbConnection) -> Maybe: User.from_sqlite3_row) -def assign_data(authconn: authdb.DbConnection, bioconn, group: Group): +def assign_data(authconn: authdb.DbConnection, bioconn, group: Group, admin: User): """Do actual data assignments.""" try: - for resource in default_resources(authconn, group): + for resource in default_resources(authconn, group, admin): assign_data_to_resource(authconn, bioconn, resource, group) return 1 @@ -76,9 +76,10 @@ if __name__ == "__main__": if Path(authdbpath).exists(): with (authdb.connection(authdbpath) as authconn, biodb.database_connection(mysqldburi) as bioconn): + admin = sys_admins(authconn)[0] return resources_group(authconn).maybe( 1, - lambda group: assign_data(authconn, bioconn, group)) + lambda group: assign_data(authconn, bioconn, group, admin)) logging.error("There is no such SQLite3 database file.") return 1 -- cgit 1.4.1