From 4dd67293c9bb515514bb905ad8a965caf021aac2 Mon Sep 17 00:00:00 2001 From: Munyoki Kilyungi Date: Wed, 6 Mar 2024 12:43:30 +0300 Subject: Remove "raise" in auth.db Protocol classes. * gn_auth/auth/db/protocols.py (DbCursor): Remove "raise" in DBCursor Protocol. See: --- gn_auth/auth/db/mariadb.py | 3 --- gn_auth/auth/db/protocols.py | 5 ----- gn_auth/auth/db/sqlite3.py | 3 --- 3 files changed, 11 deletions(-) (limited to 'gn_auth/auth') diff --git a/gn_auth/auth/db/mariadb.py b/gn_auth/auth/db/mariadb.py index 2d0cbbf..a36e9d3 100644 --- a/gn_auth/auth/db/mariadb.py +++ b/gn_auth/auth/db/mariadb.py @@ -11,15 +11,12 @@ class DbConnection(Protocol): """Type annotation for a generic database connection object.""" def cursor(self, *args, **kwargs) -> Any: """A cursor object""" - raise NotImplementedError def commit(self, *args, **kwargs) -> Any: """Commit the transaction.""" - raise NotImplementedError def rollback(self) -> Any: """Rollback the transaction.""" - raise NotImplementedError def parse_db_url(sql_uri: str) -> Tuple: """Parse SQL_URI env variable note:there is a default value for SQL_URI so a diff --git a/gn_auth/auth/db/protocols.py b/gn_auth/auth/db/protocols.py index 9d953cd..16ba039 100644 --- a/gn_auth/auth/db/protocols.py +++ b/gn_auth/auth/db/protocols.py @@ -5,23 +5,18 @@ class DbCursor(Protocol): """Type annotation for a generic database cursor object.""" def execute(self, *args, **kwargs) -> Any: """Execute a single query""" - raise NotImplementedError def executemany(self, *args, **kwargs) -> Any: """ Execute parameterized SQL statement sql against all parameter sequences or mappings found in the sequence parameters. """ - raise NotImplementedError def fetchone(self, *args, **kwargs): """Fetch single result if present, or `None`.""" - raise NotImplementedError def fetchmany(self, *args, **kwargs): """Fetch many results if present or `None`.""" - raise NotImplementedError def fetchall(self, *args, **kwargs): """Fetch all results if present or `None`.""" - raise NotImplementedError diff --git a/gn_auth/auth/db/sqlite3.py b/gn_auth/auth/db/sqlite3.py index 9849b59..12a46c7 100644 --- a/gn_auth/auth/db/sqlite3.py +++ b/gn_auth/auth/db/sqlite3.py @@ -14,15 +14,12 @@ class DbConnection(Protocol): """Type annotation for a generic database connection object.""" def cursor(self) -> Any: """A cursor object""" - raise NotImplementedError def commit(self) -> Any: """Commit the transaction.""" - raise NotImplementedError def rollback(self) -> Any: """Rollback the transaction.""" - raise NotImplementedError @contextlib.contextmanager def connection(db_path: str, row_factory: Callable = sqlite3.Row) -> Iterator[DbConnection]: -- cgit v1.2.3