From 8bb9c54d2eb7b4ae2d330a588eff32feceb4324f Mon Sep 17 00:00:00 2001 From: Pjotr Date: Wed, 11 Nov 2026 14:49:16 +0000 Subject: plot/bulklmm: the 0.05 and 0.01 lines, never 0.10 unless asked Checked what the plot actually draws: it has never drawn the alpha 0.10 line -- the plotter matches 0.05 and 0.01 only. What lists all three is the reply's notes ("alpha 0.01: LOD 4.58, alpha 0.05: 3.65, alpha 0.1: 3.50"), which is where the 0.10 came from. Still, the point stands on its own: 0.10 is the loosest bar in the set and drawing it invites reading it as the line to clear. So the defaults are stated and pinned -- 0.05 and 0.01 on the plot, 0.10 only on request (?all_thresholds=true, or an explicit ?thresholds=) -- alongside GEMMA's Bonferroni, which is opt-in for the same reason: a reference line is an annotation, not a result. tests/bulklmm.rs counts the lines: exactly two by default, and no alpha 0.10 label. --- docs/bulklmm.md | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'docs') diff --git a/docs/bulklmm.md b/docs/bulklmm.md index 86b08dd..fbb3b37 100644 --- a/docs/bulklmm.md +++ b/docs/bulklmm.md @@ -83,6 +83,11 @@ matrices of this shape. `scripts/bulklmm_scan.jl` therefore: * **caches the parsed matrix and the kinship** per panel (`read 1.3 → 0.4 s`, kinship `0.9 → 0`); * **caps BLAS** at 4 threads when serial, 1 per block when parallel; +* draws two reference lines: the genome-wide alpha 0.05 and the stricter + alpha 0.01. The reply reports alpha 0.10 as well, but that is the loosest + bar in the set, so it is drawn only on request (`?all_thresholds=true`, or an + explicit `?thresholds=`), and GEMMA's Bonferroni line on `/plot/gemma` is + opt-in in the same spirit; * reports what ran in the reply: `julia threads 4, blocks 4, BLAS threads 96 | read 1.5 s, scan 10.5 s`. -- cgit 1.4.1