From f0192be68ac1c1e1f533c0266d1f0b6165bbd9ca Mon Sep 17 00:00:00 2001 From: Munyoki Kilyungi Date: Wed, 2 Jul 2025 22:03:24 +0300 Subject: Fix minor bug in how reviews and approvals are added to LMDB. Signed-off-by: Munyoki Kilyungi --- gn3/db/case_attributes.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'gn3/db/case_attributes.py') diff --git a/gn3/db/case_attributes.py b/gn3/db/case_attributes.py index df09e75..46c4480 100644 --- a/gn3/db/case_attributes.py +++ b/gn3/db/case_attributes.py @@ -302,8 +302,10 @@ def apply_change(cursor, change_type: EditStatus, change_id: int, directory: Pat "SET status = %s " "WHERE id = %s", (str(change_type), change_id)) - review_ids.discard(change_id) + if rejections := txn.get(b"rejected"): + rejected_ids = pickle.loads(rejections) rejected_ids.add(change_id) + review_ids.discard(change_id) txn.put(b"review", pickle.dumps(review_ids)) txn.put(b"rejected", pickle.dumps(rejected_ids)) return True @@ -375,10 +377,10 @@ def apply_change(cursor, change_type: EditStatus, change_id: int, directory: Pat (str(change_type), change_id)) if approvals := txn.get(b"approved"): approved_ids = pickle.loads(approvals) - review_ids.discard(change_id) - approved_ids.add(change_id) - txn.put(b"review", pickle.dumps(review_ids)) - txn.put(b"approvals", pickle.dumps(approved_ids)) + approved_ids.add(change_id) + review_ids.discard(change_id) + txn.put(b"review", pickle.dumps(review_ids)) + txn.put(b"approved", pickle.dumps(approved_ids)) return True case _: raise ValueError -- cgit 1.4.1