From 13c4e1bbe6f30454c06235698efad146d99116dd Mon Sep 17 00:00:00 2001 From: BonfaceKilz Date: Fri, 23 Jul 2021 13:00:37 +0300 Subject: sql: metadata_audit: Make char-set encoding explicit(utf8mb4) See: https://www.eversql.com/mysql-utf8-vs-utf8mb4-whats-the-difference-between-utf8-and-utf8mb4/ --- sql/update/metadata_audit.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/update/metadata_audit.sql b/sql/update/metadata_audit.sql index 514a2fc..5055666 100644 --- a/sql/update/metadata_audit.sql +++ b/sql/update/metadata_audit.sql @@ -26,4 +26,4 @@ CREATE TABLE metadata_audit ( json_diff_data VARCHAR(2048) NOT NULL, time_stamp timestamp DEFAULT CURRENT_TIMESTAMP NOT NULL, CHECK (JSON_VALID(json_diff_data)) -); +) CHARACTER SET 'utf8mb4'; -- cgit v1.2.3 From cbb8029746400a299b9c65c5cd7be9a38cade189 Mon Sep 17 00:00:00 2001 From: zsloan Date: Mon, 26 Jul 2021 01:08:19 -0500 Subject: Check if corr_coefficient is NaN, since apparently it's stored as NaN instead of None when it can't be calculcated (which was messing up sorting); it may also be okay to remove the None check, but leaving it for now (#28) --- gn3/computations/correlations.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gn3/computations/correlations.py b/gn3/computations/correlations.py index bc738a7..56f483c 100644 --- a/gn3/computations/correlations.py +++ b/gn3/computations/correlations.py @@ -1,4 +1,5 @@ """module contains code for correlations""" +import math import multiprocessing from typing import List @@ -90,7 +91,7 @@ def compute_sample_r_correlation(trait_name, corr_method, trait_vals, target_values=sanitized_target_vals, corr_method=corr_method) - if corr_coefficient is not None: + if corr_coefficient is not None and not math.isnan(corr_coefficient): return (trait_name, corr_coefficient, p_value, num_overlap) return None -- cgit v1.2.3