From 361b016764205845b8175100fe21a5455968c087 Mon Sep 17 00:00:00 2001
From: Arun Isaac
Date: Wed, 28 Sep 2022 13:37:10 +0530
Subject: Do not assume transactions in database connections.

Not all database queries need transactions. If transactions are
required, they should be made a separate context manager and called
only when required.

* wqflask/wqflask/database.py (database_connection): Do not rollback
or commit.
---
 wqflask/wqflask/database.py | 5 -----
 1 file changed, 5 deletions(-)

(limited to 'wqflask')

diff --git a/wqflask/wqflask/database.py b/wqflask/wqflask/database.py
index d392f1d1..84c494c5 100644
--- a/wqflask/wqflask/database.py
+++ b/wqflask/wqflask/database.py
@@ -59,11 +59,6 @@ def database_connection() -> Iterator[Connection]:
     )
     try:
         yield connection
-    except Exception:
-        connection.rollback()
-        raise
-    else:
-        connection.commit()
     finally:
         connection.close()
 
-- 
cgit v1.2.3