aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-22Update bug_report templateBonfaceKilz
* .github/ISSUE_TEMPLATE/bug_report.md: Update environment setup section
2020-09-18Made some style changes with whitespace/line-breakszsloan
2020-09-18Made a bunch of changes to move trait page DataTables initialization tozsloan
a separate file (initialize_show_trait_tables.js). The biggest complication was getting the order of attributes in the rows to sync with the order of atribute namees in the column headers. Previously this logic was all in the template. * wqflask/base/webqtlCaseData.py - added attribute first_attr_col as a very awkward solution to passing the column position into the column render function in situations where there are case attribute columns (which can be variable in number) * wqflask/wqflask/show_trait/show_trait.py - Replace "attribute_names" in js_data with "attributes" (which allows the JS access to more information) and also pass new se_exists and has_num_cases variables with js_data, so the javascript has access to whether or not those columns exist in the table * wqflask/wqflask/static/new/javascript/show_trait.js - Change case attribute-related logic to use js_data.attributes instead of js_data.attribute_names * wqflask/wqflask/templates/show_trait.html - Removed table initialization from template * wqflask/wqflask/static/new/javascript/initialize_show_trait_tables.js - new file that initializes tables and reproduces what the template logic used to do with JS logic
2020-09-18Apply pep8 formattingBonfaceKilz
2020-09-17Mock "SECRET_HMAC_CODE"BonfaceKilz
* wqflask/tests/utility/test_hmac.py: Mock app.config's "SECRET_HMAC_CODE" value.
2020-09-17Merge pull request #443 from BonfaceKilz/tests/test-auth-and-utf8BonfaceKilz
Tests/test auth and utf8
2020-09-17Apply pep8BonfaceKilz
* wqflask/utility/hmac.py: Apply pep8 and fix typo.
2020-09-17Add tests for hmac utilityBonfaceKilz
* wqflask/tests/utility/test_hmac.py: New tests.
2020-09-16Changed references to se_exists to just get it as a property ofzsloan
SampleList instead of calling the method * wqflask/wqflask/show_trait/show_trait.py - see above * wqflask/wqflask/templates/show_trait.html - see above + removed some commented out code
2020-09-16Changed se_exists to a property so the SampleList instance can includezsloan
that when converted to a dict (which is needed to use it in the javascript) * wqflask/wqflask/show_trait/SampleList.py - Directly set se_exists as a property of SampleList instead of requiring a method be called; I could have set self.se_exists by calling the se_exists method, but that would have resulted in the convoluted line "self.se_exists = self.se_exists()" and the se_exists method only consisted of one line anyways
2020-09-16Applied PEP8 and removed commented out codezsloan
2020-09-16Add new tests for "base/trait.py"BonfaceKilz
* wqflask/tests/base/test_trait.py: New tests.
2020-09-16Apply pep8BonfaceKilz
* wqflask/utility/authentication_tools.py: Apply pep8 formatting to file.
2020-09-16Add tests for "add_new_resource" methodBonfaceKilz
* wqflask/tests/utility/test_authentication_tools.py: Add them.
2020-09-16Remove unnecessary if branchBonfaceKilz
* wqflask/utility/authentication_tools.py (check_resource_availability): Combine if statements into one boolean check in one if branch.
2020-09-16Add tests for authentication toolsBonfaceKilz
Catches bugs in: - https://github.com/genenetwork/genenetwork2/pull/422/commits/70dbeeb5832711ed5271434e482c18bc7ea095b8 * wqflask/tests/utility/test_authentication_tools.py: New file. Add tests for "check_resource_availability".
2020-09-15Fix failing testsBonfaceKilz
* wqflask/tests/base/test_data_set.py: Update failing tests introduced by the change in 301bdd2f4.
2020-09-15Added scroller to trait page and changed sample tables to use itzsloan
* wqflask/wqflask/templates/show_trait.html - Imported scroller (from the Google cdn temporarily for testing) and activated it for the sample tables, as well as disabled options that conflicted with it (like paging: false)
2020-09-14Merge branch 'scroller_testing' of github.com:zsloan/genenetwork2 into testingzsloan
2020-09-13Added in-progress info-page to views.py as well as in-progresszsloan
authorization/security guide * wqflask/wqflask/views.py - Added endpoint for info page and authorization/security tutorial
2020-09-11Wrote code and template for reproducing GN1's Info Page (page thatzsloan
displays info about a dataset + download links for its data) * wqflask/wqflask/db_info.py - Python that pulls the info out of the DB and parses the download links from the ipfs response * wqflask/wqflask/templates/info_page.html - template for displaying db info; need to make a lot of changes to its format/aesthetics
2020-09-10Modified "natural-minus-na" sort function to treat an array of valueszsloan
as equivalent to "N/A" (since different tables sometimes include other values that imply there's no value) and applied it to some extra columns in the Interval Analyst table * wqflask/wqflask/static/new/javascript/search_results.js - Modified sort_NAs function to take an array of "N/A"-equivalent values instead of just comparing against the string "N/A" * wqflask/wqflask/templates/mapping_results.html - Applied "natural-minus-na" sort method to several columns that include "--" in the Interval Analyst table
2020-09-10Fixed several sorting issues and moved orderDataType definitions intozsloan
search_results.js since all the tables that use them import that file (that file's name needs to be changed, though) * wqflask/wqflask/static/new/javascript/search_results.js - Added the dom-checkbox and dom-inner-text order types into this file; they were previously duplicated across several template files * wqflask/wqflask/templates/gsearch_gene.html - Added dom-inner-text order type to relevant columns with hyperlink contents and disabled deferRender since it conflicted with use of both pagination and orderDataType for sorting * wqflask/wqflask/templates/gsearch_pheno.html - Same as above * wqflask/wqflask/templates/mapping_results.html - Added dom-inner-text for a few columns that have hyperlink values - still need to modify natural-minus-na to also include other "N/A"-equivalent values like "--" * wqflask/wqflask/templates/search_result_page.html Removed the dom-checkbox and dom-inner-text order types from this file since they were moved to search_results.js
2020-09-08Changed the Add button color for all the different pages that use itzsloan
* wqflask/wqflask/templates/collections/view.html - changed Add button color * wqflask/wqflask/templates/correlation_matrix.html - changed Add button color * wqflask/wqflask/templates/correlation_page.html - changed Add button color * wqflask/wqflask/templates/mapping_results.html - changed Add button color * wqflask/wqflask/templates/search_result_page.html - changed Add button color
2020-09-08Search code now checks if there are more than 50,000 results beforezsloan
running the code that queries the DB for max LRS locus information (which is what takes the most time to run) and sets a variable that indicates to the template (search_results.html) that it shouldn't show the results * wqflask/wqflask/search_results.py - Check number of results from base query in order to prevent certain searches from running too long
2020-09-08Changed regular and global search results table to use the new sortzsloan
method that always places NAs at bottom, changed the Add to Collection button's color, and added something to the regular search page template to display alternative text if there are more than 50000 results * wqflask/wqflask/templates/gsearch_gene.html - Added natural-minus-na sort to certain columns and changed Add button color * wqflask/wqflask/templates/gsearch_pheno.html - Added natural-minus-na sort to certain columns and changed Add button color * wqflask/wqflask/templates/search_result_page.html - Added natural-minus-na sort to certain columns, changed Add button color, and added template logic that shows alternative text if there are more than 50,000 results
2020-09-08Added a sort function (derived from the natural sort import) that alwayszsloan
places N/As at the bottom regardless of search direction * wqflask/wqflask/static/new/javascript/search_results.js - created "natural-minus-na" sort
2020-09-04Merge pull request #437 from ↵BonfaceKilz
BonfaceKilz/fix/use-correct-path-give-a-path-location Fix/use correct path give a path location
2020-09-04Update how static js/ css files are fetchedBonfaceKilz
* wqflask/wqflask/views.p:(css, js) Add "css" router decorator. Also, if "js_alt" is in path, fetch the file from "GUIX_PROFILE/share/javascript" instead of the default directory: "GUIX_PROFILE/share/genenetwork2/javascript" See: <https://github.com/genenetwork/genenetwork2/issues/436>
2020-09-04Fix false positive testsBonfaceKilz
* test/requests/link_checker.py: (verify_static_file): Add it. Verify that a static link is fetched by checking for the message "Error: 404 not Found" in page. (check_package_js_files): Add appropriate 'js' or 'css' prefix.
2020-09-01There was a missing quote in one of the javascript imports added by thezsloan
PR changing them to get fetched from GUIX; I need to check and see if there are other situations like this * wqflask/wqflask/templates/mapping_results.html - Added missing quote
2020-09-01Merge branch 'testing' of github.com:genenetwork/genenetwork2 into testingzsloan
2020-09-01Fixed indent issue that could cause error when showing the haplotypezsloan
analyst in the mapping chromosome view * wqflask/wqflask/marker_regression/display_mapping_results.py - Indented a bit of code that was wrongly indented in such a way that the variable "ind" wasn't set if "plotbxd" is 0
2020-09-01Merge pull request #434 from BonfaceKilz/Build/use-md5-js-from-guixBonfaceKilz
Build/use md5 js from guix
2020-09-01Add check for "md5.min.js" libraryBonfaceKilz
* test/requests/link_checker.py: Add it.
2020-09-01Use "md5.min.js" from guixBonfaceKilz
2020-09-01Merge pull request #433 from BonfaceKilz/Build/remove-cdnsBonfaceKilz
Build/remove cdns
2020-09-01Check availability of several js and css filesBonfaceKilz
* test/requests/link_checker.py: Check availability of: chroma.min.js; d3-tip.js; d3.min.js; underscore.min.js; nv.d3.min.css; and jquery.qtip.min.js
2020-09-01Remove commented out script tags that references CDNsBonfaceKilz
2020-09-01Replace CDNs with packages from guixBonfaceKilz
2020-09-01Merge pull request #432 from BonfaceKilz/Fix/add-missing-apostropheBonfaceKilz
Add missing apostrophe in url_for args
2020-09-01Add missing apostrophe in url_for argsBonfaceKilz
2020-08-31Merge pull request #431 from BonfaceKilz/Build/add-d3-tipBonfaceKilz
Use d3-tip from guix
2020-08-31Fixed text on not_authenticated to use proper grammarzsloan
* wqflask/wqflask/templates/new_security/not_authenticated.html - Changed "this" to "these" since "data" is plural
2020-08-31Merge branch 'testing' of github.com:genenetwork/genenetwork2 into testingzsloan
2020-08-31Fixed issue that was causing updating resource default privileges to notzsloan
work * wqflask/utility/redis_tools.py - There was an issue where resources wouldn't be updated if they already existed. This is because the code didn't yet account for the "update" tag (that is meant to give the option of preventing updating resources when running the script to enter all resources into Redis). I changed the logic to add a resource if "update" is True or the resource doesn't already exist (so it won't if update is False and the resource exists).
2020-08-31Add check for "d3-tip.js" js libraryBonfaceKilz
* test/requests/link_checker.py (check_packaged_js_files): Add it.
2020-08-31Merge pull request #429 from BonfaceKilz/chore/add-gh-templatesBonfaceKilz
Add github templates for filing bugs, user stories/ features and PRs
2020-08-31Use d3-tip from guixBonfaceKilz
2020-08-31Merge pull request #430 from BonfaceKilz/Build/add-chroma-jsBonfaceKilz
Build/add chroma js