summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander_Kabui2024-09-13 11:49:33 +0300
committerAlexander_Kabui2024-09-13 11:49:33 +0300
commitcb3784418a6f7d002285137cbd945bfe354f53f8 (patch)
tree00ae8bdce5bed5b2d7f4730caa6c209c25080c8c
parent92fdd3bff1eab10036d897883fa60c6c6d6e69b5 (diff)
downloadgn-gemtext-cb3784418a6f7d002285137cbd945bfe354f53f8.tar.gz
Update issue: gnqa: gnqa integration to global search.
-rw-r--r--issues/gnqa/gnqa_integration_to_global_search_Design.gmi27
1 files changed, 19 insertions, 8 deletions
diff --git a/issues/gnqa/gnqa_integration_to_global_search_Design.gmi b/issues/gnqa/gnqa_integration_to_global_search_Design.gmi
index 94597de..ff8854b 100644
--- a/issues/gnqa/gnqa_integration_to_global_search_Design.gmi
+++ b/issues/gnqa/gnqa_integration_to_global_search_Design.gmi
@@ -52,12 +52,23 @@ It is possible to generate potential questions based on the user's search and re
## Tasks
-* [ ] Initiate a background task from HTMX to Fahamu once the search page loads.
-* [ ] Query Fahamu for data.
-* [ ] Cache results from Fahamu.
-* [ ] Render the UI page with the query and answer.
-* [ ] For "See more," render the entire GNQA page with the query, answer, references, and PubMed data.
-* [ ] Implement parsing for Xapian queries to normal queries.
-* [ ] Implement error handling.
+* [x] Initiate a background task from HTMX to Fahamu once the search page loads.
+* [x] Query Fahamu for data.
+* [x] Cache results from Fahamu.
+* [x] Render the UI page with the query and answer.
+* [x] For "See more," render the entire GNQA page with the query, answer, references, and PubMed data.
+* [x] Implement parsing for Xapian queries to normal queries.
+* [x] Implement error handling.
* [ ] reimplement how gnqa uses GN-AUTH in gn3.
-* [ ] Query Fahamu to generate possible questions based on certain keywords.
+* [x] Query Fahamu to generate possible questions based on certain keywords.
+
+
+## Notes
+From the latest Fahamu API docs, they have implemented a way to include subquestions by setting `amplify=True` for the POST request. We also have our own implementation for parsing text to extract questions.
+
+## PRs Merged Related to This
+
+=> https://github.com/genenetwork/genenetwork2/pull/868
+=> https://github.com/genenetwork/genenetwork2/pull/862
+=> https://github.com/genenetwork/genenetwork2/pull/867
+=> https://github.com/genenetwork/genenetwork3/pull/191 \ No newline at end of file